Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new poll 2024-07-29 #2703

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Conversation

CivicSage3
Copy link
Collaborator

SparkLend Ethereum - Activate Lido LST Interest Rate Model (IRM) - July 29, 2024.md

Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. The title suggestion is the only blocking item from the review. Please also consider if more resource links should be added, our team supports either adding them in, or leaving as is.


## Review

The community can vote in this poll to express support or opposition to activating the Lido LST yield oracle and the linked Interest Rate Model for the ETH market on SparkLend with the following parameters:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abbreviations should be reviewed here. The title introduces LST and IRM as abbreviations. I would suggest they both still be written "Liquid Staking (LST)" and "Interest Rate Model (IRM)". Regardless, the sentence should make sure the same format is used for LST and IRM.

@MakerJanSky
Copy link
Collaborator

MakerJanSky commented Jul 29, 2024

Poll Review

Admin I

  • Is the poll expected this week?
  • Do you understand the question the poll is asking of governance?

Content

  • Does the filename have the .md extension?
  • Does the filename contain banned characters? <>:"/?*|
  • Do the titles contain banned characters? <>:"/?*
  • Are the poll options too long? (Less than 30 characters as a rough guide)
  • Do the options have distinct numbers in the preamble?
  • Are the start and end dates present and correct?
  • Does the vote type match desired vote type for the poll?
  • Is the default option correct in metadata?
  • Is the preamble ready for submission?
  • Is the vote descriptor present and does it match the vote type?
  • Are the 'Review', 'Outcomes', and 'Resources' sections present?
  • Will the Data/parameters present in the poll be accurate at the time the poll is live?
  • Are the dates correct within the text?
  • Are all the relevant links provided?
  • Are all the links working?
  • Are the outcomes clear and comprehensive?
  • Do any '$' parameter signifiers remain?
  • Does the poll summary accurately reflect the poll content?
  • Read the poll text in full and highlight any other potential issues.

Admin II

  • Raise any issues with the poll author via review on GitHub.
  • Inform the reviewer when the poll passes review.

CivicSage3 and others added 6 commits July 29, 2024 08:04
…st Rate Model (IRM) - July 29, 2024.md

Co-authored-by: MakerJanSky <137431968+MakerJanSky@users.noreply.github.com>
Co-authored-by: blimpa <72349134+blimpa@users.noreply.github.com>
Co-authored-by: blimpa <72349134+blimpa@users.noreply.github.com>
Add reference link

Co-authored-by: blimpa <72349134+blimpa@users.noreply.github.com>
Copy link
Collaborator

@MakerJanSky MakerJanSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, all.

@VoteWizard VoteWizard merged commit c53d928 into makerdao:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants