This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Comment CollateralOpts & update README.md #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canokaue
commented
Nov 30, 2021
canokaue
commented
- create variable comments in CollateralOpts.sol;
- add breakerTolerance, kprFlatReward & kprPctReward variables to README.md examples;
- add setIlkAutoLineParameter method call to README.md example;
- change initStairstepExponentialDecrease to setStairstepExponentialDecrease;
- match Maker governance proposal parameters with CollateralOpts.
…FlatReward & kprPctReward to README.md, add setIlkAutoLineParameter method call to README.md
…lOpts.sol variable comments & add license + natspec comment
canokaue
changed the title
|
Hey @brianmcmichael thank you so much for the feedback! I've added your suggestions to the latest commit 6ad733d4050bb9234b84ac81c400c052c21fa107, please let me know if it's all good now. |
iamchrissmith
suggested changes
Jan 25, 2022
There was a problem hiding this comment.
@canokaue this is looking good, I made a couple of wording suggestions
Co-authored-by: Chris Smith <1408372+iamchrissmith@users.noreply.github.com>
Co-authored-by: Chris Smith <1408372+iamchrissmith@users.noreply.github.com>
Co-authored-by: Chris Smith <1408372+iamchrissmith@users.noreply.github.com>
Co-authored-by: Chris Smith <1408372+iamchrissmith@users.noreply.github.com>
…nd extend example
Co-authored-by: Brian L. McMichael <brian@brianmcmichael.com>
Co-authored-by: Brian L. McMichael <brian@brianmcmichael.com>
Co-authored-by: Brian L. McMichael <brian@brianmcmichael.com>
brianmcmichael
approved these changes
Feb 17, 2022
|
@brianmcmichael @iamchrissmith thanks for reviewing and approving the PR. I believe we're good to merge, but I can't do it on my end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.