-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fetch for categories json on validation #215
Add fetch for categories json on validation #215
Conversation
This pull request has been linked to Shortcut Story #481: Update categories in the validator function for when polls are created. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dux-core-unit/governance-portal-v2/88fkQKwM5pFLtSnrkhwUQzCgQ7mj |
Codecov Report
@@ Coverage Diff @@
## develop #215 +/- ##
===========================================
- Coverage 38.19% 38.18% -0.01%
===========================================
Files 62 62
Lines 1605 1608 +3
Branches 505 503 -2
===========================================
+ Hits 613 614 +1
- Misses 985 987 +2
Partials 7 7
Continue to review full report at Codecov.
|
…al-v2 into chore/sc-481/update-categories-in-the-validator-function
Link to Clubhouse story
https://app.shortcut.com/dux-makerdao/story/481/update-categories-in-the-validator-function-for-when-polls-are-created
What does this PR do?
When validating poll markdown (
polling/create
), this update will now fetch categories dynamically from the community repo. If it fails, it will fallback to the hardcoded categories we have been relying on.Steps for testing:
Go to
polling/create
, ensure validation worksAdd a GIF: