Add hat badge to exec detail #221
Conversation
|
This pull request has been linked to Shortcut Story #563: Show governing proposal status on Exec detail page. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dux-core-unit/governance-portal-v2/8e9XKcp3a547Gj1u7CetZfobgNFE |
Codecov Report
@@ Coverage Diff @@
## develop #221 +/- ##
===========================================
- Coverage 38.22% 37.65% -0.57%
===========================================
Files 62 60 -2
Lines 1609 1604 -5
Branches 503 505 +2
===========================================
- Hits 615 604 -11
- Misses 987 993 +6
Partials 7 7
Continue to review full report at Codecov.
|
| @@ -25,7 +25,9 @@ import getMaker, { getNetwork, personalSign } from 'lib/maker'; | |||
| import { fadeIn, slideUp } from 'lib/keyframes'; | |||
| import { getEtherscanLink, sortBytesArray } from 'lib/utils'; | |||
| import { fetchJson } from 'lib/fetchJson'; | |||
| import { useLockedMkr, useHat, useAllSlates } from 'lib/hooks'; | |||
| import { useLockedMkr } from 'lib/hooks'; | |||
| import { useHat } from 'modules/executive/hooks/useHat'; | |||
| @@ -84,7 +84,7 @@ export default function ExecutiveCard({ proposal, isHat, ...props }: Props): JSX | |||
| View proposal | |||
| </Button> | |||
| </Link> | |||
| {isHat && proposal.address !== '0x0000000000000000000000000000000000000000' ? ( | |||
| {isHat && proposal.address !== ZERO_ADDRESS ? ( | |||
adamgoth
deleted the
feature/sc-563/show-governing-proposal-status-on-exec-detail
branch
Link to Clubhouse story
https://app.shortcut.com/dux-makerdao/story/563/show-governing-proposal-status-on-exec-detail-page
What does this PR do?
Adds "Governing Proposal" badge to exec detail page
Steps for testing:
Screenshots (if relevant):
Add a GIF: