Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR: v0.2.5 #254

Merged
merged 42 commits into from
Dec 6, 2021
Merged

Release PR: v0.2.5 #254

merged 42 commits into from
Dec 6, 2021

Conversation

rafinskipg
Copy link
Contributor

@rafinskipg rafinskipg commented Nov 26, 2021

Release v0.2.5 - Alphonso Hartlaub's Duck - (Pteronetta hartlaubii)

What is included

…ates info (#251)

* improvements on data fetching for delegates, reorganizing delegates info

* include api docs
@vercel
Copy link

vercel bot commented Nov 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dux-core-unit/governance-portal-v2/DiWmeTh91y9wftzzvDD9hzxT2GYw
✅ Preview: https://staging-vote.vercel.app

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #254 (0181d10) into master (1347fa4) will decrease coverage by 2.28%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   34.77%   32.49%   -2.29%     
==========================================
  Files          62       60       -2     
  Lines        1642     1545      -97     
  Branches      528      516      -12     
==========================================
- Hits          571      502      -69     
+ Misses       1064     1036      -28     
  Partials        7        7              
Impacted Files Coverage Δ
lib/theme.js 57.14% <ø> (ø)
lib/utils.ts 63.63% <ø> (ø)
pages/account.tsx 77.41% <ø> (ø)
pages/address/[address]/index.tsx 0.00% <0.00%> (ø)
pages/api/address/[address]/delegated-to.ts 0.00% <0.00%> (ø)
pages/api/address/[address]/index.ts 0.00% <ø> (ø)
pages/api/address/[address]/stats.ts 0.00% <0.00%> (ø)
...ages/api/delegates/delegation-history/[address].ts 0.00% <0.00%> (ø)
pages/esmodule.tsx 62.71% <ø> (ø)
pages/executive.tsx 57.97% <ø> (+10.86%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1347fa4...0181d10. Read the comment docs.

* hot fix tally

* hotfix: Remove polling bars on empty results/votes and fix NaN issue

Co-authored-by: Phil Bain <bain.pmcg@gmail.com>
* Show percentage of MKR delegated

* Add a skeletok while loading percent of delegates
* Fix polling date filter issue

* Include feedback from review
* implement active and ended filters

* lint

* fix active polls tests

* change default behaviour of polling filters

* build

* Count on filter

Co-authored-by: Phil Bain <bain.pmcg@gmail.com>
* Add test for empty tally

* do not ignore helpers tests

* add explanation

* Fix ignore pattern

* Update getPollTally.spec.ts
@b-pmcg b-pmcg marked this pull request as ready for review December 6, 2021 23:04
@b-pmcg b-pmcg merged commit 6a44c81 into master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants