Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bars ui if vote is 0 #258

Merged
merged 3 commits into from
Nov 29, 2021
Merged

remove bars ui if vote is 0 #258

merged 3 commits into from
Nov 29, 2021

Conversation

rafinskipg
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 29, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dux-core-unit/governance-portal-v2/CWmx6fBcaEB5Dqt3W4h9wGQZP8cZ
✅ Preview: https://governance-portal-v2-git-fix-remove-bars-dux-core-unit.vercel.app

rafinskipg
rafinskipg commented Nov 29, 2021
View reviewed changes
modules/polling/components/PollOverviewCard.tsx
@@ -190,15 +190,22 @@ export default function PollOverviewCard({

{poll.voteType === POLL_VOTE_TYPE.PLURALITY_VOTE && (
<Box sx={{ width: bpi > 0 ? '265px' : '100%', p: bpi > 0 ? 0 : 2 }}>
{tally && <PollVotePluralityResultsCompact tally={tally} showTitles={false} />}
{tally && tally.totalMkrParticipation > 0 && (
<PollVotePluralityResultsCompact tally={tally} showTitles={false} />
Copy link
Contributor Author

@rafinskipg rafinskipg Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hide tally if totalMkrParticipation

rafinskipg
rafinskipg commented Nov 29, 2021
View reviewed changes
modules/polling/components/PollOverviewCard.tsx
<PollWinningOptionBox tally={tally} poll={poll} />

{tally && tally.totalMkrParticipation > 0 && (
<Box>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "leading option from card if mkr is 0"

@codecov
Copy link

codecov bot commented Nov 29, 2021 •
edited
Loading

Codecov Report

Merging #258 (cd6ea76) into master (62095f7) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head cd6ea76 differs from pull request most recent head b5b3112. Consider uploading reports for the commit b5b3112 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   34.83%   34.77%   -0.07%     
==========================================
  Files          62       62              
  Lines        1639     1642       +3     
  Branches      525      528       +3     
==========================================
  Hits          571      571              
- Misses       1061     1064       +3     
  Partials        7        7
Impacted Files Coverage Δ
pages/polling/[poll-hash].tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62095f7...b5b3112. Read the comment docs.

@rafinskipg rafinskipg merged commit 1347fa4 into master Nov 29, 2021
@rafinskipg rafinskipg deleted the fix/remove-bars branch November 29, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-pmcg b-pmcg b-pmcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafinskipg @b-pmcg