Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix poll parameters filters #520

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Conversation

rafinskipg
Copy link
Contributor

Link to Shortcut ticket:

https://app.shortcut.com/dux-makerdao/story/1351/updates-to-poll-filters

What does this PR do?

Restore poll type filter with the new poll metadata
image

@vercel
Copy link

vercel bot commented Jun 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:35AM (UTC)

Copy link
Collaborator

@adamgoth adamgoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noticed we have Majority as an option but no polls with that value type. Should we exclude it if there are 0 results from all polls?

@tyler17
Copy link
Collaborator

tyler17 commented Jun 20, 2022

LGTM. Noticed we have Majority as an option but no polls with that value type. Should we exclude it if there are 0 results from all polls?

That makes sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants