Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default provider from getENS #524

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Remove default provider from getENS #524

merged 7 commits into from
Jun 22, 2022

Conversation

adamgoth
Copy link
Collaborator

@adamgoth adamgoth commented Jun 22, 2022

Significantly reduce the number of calls from ethers by passing getENS the connected provider library instead of using ethers default provider

Cleans up Davatar, removes default provider usage

Prevents gas price fetching not on mainnet

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 0:55AM (UTC)

Copy link
Collaborator

@b-pmcg b-pmcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it's reducing calls let's ship it

@b-pmcg b-pmcg merged commit d7c1a7f into develop Jun 22, 2022
@b-pmcg b-pmcg deleted the adam/delegate-reqs branch June 22, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants