Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pool to liquidity panel #809

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Add new pool to liquidity panel #809

merged 1 commit into from
Jul 21, 2023

Conversation

adamgoth
Copy link
Collaborator

Adds new pool and distinguishes between the two uniswap v2 pools

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview Jul 21, 2023 9:27am

@what-the-diff
Copy link

what-the-diff bot commented Jul 21, 2023

PR Summary

  • Addition of Two New Variables
    The code now includes uniswapV2MkrEthPool and uniswapV2MkrDaiPool. These additions aim to help manage different pools within our system more efficiently.

  • Updating the useTokenBalance Calls
    We adjusted the element that retains the token balance, to now utilize the uniswapV2MkrEth and uniswapV2MkrDai variables. This update enhances our software's ability to track token balances correctly.

  • Modification of the MkrLiquiditySidebar Component
    InThe Uniswap section, the component MkrLiquiditySidebar has been altered to show the token balances for uniswapV2MkrEth and uniswapV2MkrDai. This modification offers a better view of token balances for these specified pools, aiding in efficient management and oversight.

@tyler17 tyler17 self-requested a review July 21, 2023 19:56
Copy link
Collaborator

@tyler17 tyler17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 possible minor improvement is to sort the uniswap pools by amount of MKR in them

@b-pmcg b-pmcg merged commit ddfc183 into develop Jul 21, 2023
@b-pmcg b-pmcg deleted the add-mkr-dai-pool branch July 21, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants