Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migration issue for already linked delegate address #947

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

tyler17
Copy link
Collaborator

@tyler17 tyler17 commented Oct 24, 2024

If address is already linked to a v1 delegate, they still need to go through the v2 migration

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
governance-portal-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:40pm

Copy link

what-the-diff bot commented Oct 24, 2024

PR Summary

  • Implementation of a New Feature Checking Tool

    • We are introducing a new checking tool, useHasV1VoteDelegate, which is used to see if a chosen account also comes with a version 1 delegate contract. This tool uses the swr library - renowned for fetching and storing data. It syncs with the useContracts tool to achieve the necessary contract example.
  • Improvement in the DelegateMigrationPage

    • The DelegateMigrationPage feature now includes the newly created useHasV1VoteDelegate checking tool. This tool improves the checking process to ascertain if the latestOwnerAddress also has a v1 delegate contract. This checking point influences the states of an address association.
    • There has been an enhancement in comments to explain that it tests for the readiness for shifts from version 1 to version 2 delegate contracts.

@tyler17 tyler17 merged commit e3f5b24 into master Oct 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants