Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for X728 UPS-board #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JanneMantyharju
Copy link
Contributor

This UPS board is much preferred over Strom-pi. Not only Strom-pi has pretty braindead interface, it does not provide enough power for RPi 5 to reliable transition from external power to battery

@e100
Copy link
Collaborator

e100 commented Jan 21, 2025

I have two x728 in my panel so this is interesting. Maybe this should be renamed to geekwormups and we can add support for both? or maybe just 'ups' and we can combine various ups into a single configurable plugin? I'm even thinking we could incorporate an auto shutdown feature into the plugin so we do not need to install any external software to have that feature. It is nice to just switch off the avionics master switch and watch the PIs shutdown cleanly.

Over the last couple weeks I have been working to improve this project to include automated code testing and coverage reports using github actions, switched to pyqt6 and using pyproject.toml not requirements.txt.

Could you adjust this so it does not have merge conflicts and add some tests?
You might want to take a look at #179 as I've been switching the test code to pytest, adding more tests and setting up reusable fixtures to make testing easier. The canfix and netfix tests in #179 should provide adequate direction on how to create a test for a plugin. For an aviation application we should have 100% test coverage over all the code, #179 brings us from 18% to about 25% so far.

@JanneMantyharju
Copy link
Contributor Author

I'll see what I can do. The various UPS modules could be grouped together but the code should be in separate files or modules as the communication method varies. On the hindsight, I would not recommend strom-pi to anyone, the firmware is buggy and implementing support is difficult. This X728 is much better, only downside is that it can't readily accept +12v voltage without down converter.
It would be nice to see some ready functionality or configuration files in pyEfis that would show a warning when main power is lost and a question should the unit be shut down or left running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants