Custom new tab page

[sotpapathe]

The new tab page can now be loaded from $XDG_CONFIG_HOME/amfora/new_tab.gmi. This is documented in the default tab page. This implements what was suggested in issue #67 except for the ability to reload the new tab page, it is loaded once on startup.

• I didn't make the new tab file location configurable. It will require expanding ~ in the config option and possibly environment variables in order to honor XDG_CONFIG_HOME so I opted for a hardcoded path like the config file. If it is deemed necessary I can implement it.
• config.ConfigDir was exported to allow accessing XDG_CONFIG_HOME from outside config.
• I didn't implement the reload yet because it will require some special cases and I'm not sure where best to add them, Reload(), or hasContent() and handleURL()?

[makew0rld]

Thanks for adding this! I have some comments.

• Don't export configDir, but instead have a new exported variable called NewTabPath. The config package can do the filepath.Join(config.ConfigDir, "new_tab.gmi") work.
• Use newtab.gmi, not new_tab.gmi

I didn't make the new tab file location configurable.

All good with me.

I didn't implement the reload yet because it will require some special cases and I'm not sure where best to add them, Reload(), or hasContent() and handleURL()?

I would add a config boolean called CustomNewTab, set on startup. Then in Reload, I would add code like this:

func Reload() {
	if tabs[curTab].page.URL == "about:newtab" && config.CustomNewTab {
		// Re-render new tab, similar to Init()
		newTabContent := getNewTabContent()
		tmpTermW := termW
		renderedNewTabContent, newTabLinks = renderer.RenderGemini(newTabContent, textWidth(), leftMargin())
		newTabPage = structs.Page{
			Raw:       newTabContent,
			Content:   renderedNewTabContent,
			Links:     newTabLinks,
			URL:       "about:newtab",
			Width:     tmpTermW, // Note this line is different than from Init(), since the terminal width is known
			Mediatype: structs.TextGemini,
		}
	}

    if !tabs[curTab].hasContent() {
        return
    }
	
	// Reload func continues...
}

[sotpapathe]

Done! I didn't add the CustomNewTab boolean because if the custom new tab page is created after startup, the custom page won't appear after reloading. With the current implementation, at each reload, a custom new tab page is searched for.

[makew0rld]

Thanks! The problem with not having CustomNewTab is that if there is no new tab page, the the default new tab is still re-rendered every time you open a new tab, even if the terminal is the same size.

if the custom new tab page is created after startup, the custom page won't appear after reloading

I'm okay with this, because of the performance gain.

Once this is added, I will be happy to merge.

[sotpapathe]

Fair point, done. If a custom new tab page is present on startup, then the new tab page will always be reloaded. Otherwise it will never be reloaded, even if a custom new tab page appears later.

Should I squash my commits before merging?

[makew0rld]

Thanks for all your work! Merged. And no, you don't have to squash, I can do that with the "Squash and merge" button.

[sotpapathe]

Got it. Thanks for merging and making amfora!