Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atft fixes #342

Merged
merged 15 commits into from
Feb 12, 2021
Merged

Atft fixes #342

merged 15 commits into from
Feb 12, 2021

Conversation

makimenko
Copy link
Owner

  • export data center as module
  • fix animation subscription
  • dagre input as yaml (dynamic creation of child actors)

@makimenko makimenko enabled auto-merge February 12, 2021 15:26
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #342 (a30608d) into master (b89b4fb) will decrease coverage by 1.45%.
The diff coverage is 19.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   47.57%   46.12%   -1.46%     
==========================================
  Files          97       99       +2     
  Lines        1404     1470      +66     
  Branches      170      186      +16     
==========================================
+ Hits          668      678      +10     
- Misses        687      742      +55     
- Partials       49       50       +1     
Impacted Files Coverage Δ
...actor/data-center/atft-data-center-actor.module.ts 100.00% <ø> (ø)
...b/actor/data-center/layout/dagre-edge.component.ts 2.32% <0.00%> (-0.91%) ⬇️
...ta-center/server/server-compact-actor.component.ts 100.00% <ø> (ø)
.../src/lib/actor/ux/loader/loader-actor.component.ts 2.43% <0.00%> (-0.07%) ⬇️
...atft/src/lib/actor/ux/text/text-actor.component.ts 1.72% <0.00%> (-0.04%) ⬇️
...ojects/atft/src/lib/animation/animation.service.ts 73.33% <ø> (ø)
...s/atft/src/lib/object/mesh/video-mesh.component.ts 2.32% <0.00%> (ø)
.../data-center/layout/dagre-yaml-parser.component.ts 2.77% <2.77%> (ø)
.../data-center/layout/dagre-composition.component.ts 2.38% <7.69%> (-0.96%) ⬇️
...b/actor/data-center/layout/dagre-node.component.ts 2.77% <8.33%> (-1.23%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89b4fb...edd1fd1. Read the comment docs.

@makimenko makimenko merged commit 9801f09 into master Feb 12, 2021
@makimenko makimenko deleted the editor branch April 25, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant