Fix problem of narrow angles locateOnLine #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
requested changes
Feb 1, 2019
| @@ -540,7 +540,7 @@ L.GeometryUtil = L.extend(L.GeometryUtil || {}, { | |||
| var l1 = latlngs[i], | |||
| l2 = latlngs[i+1]; | |||
| portion = lengths[i]; | |||
| if (L.GeometryUtil.belongsSegment(point, l1, l2)) { | |||
| if (L.GeometryUtil.belongsSegment(point, l1, l2, 0.0001)) { | |||
There was a problem hiding this comment.
This value seems pretty arbitrary :) Where does it come from?
There was a problem hiding this comment.
It's arbitrary a little bit like 0.2 :) i can't put 0 because it's not possible to find the point on the line with this value, it should be because the point is on the line but i think that it's not perfectly on it.
LePetitTim
added a commit
that referenced
this pull request
Feb 1, 2019
* Fix `locateOnLine()` doesn't return correct subline (#79, thanks @LePetitTim)
|
Who is publishing on npm the new releases @leplatrem ? |
I used to do it... do you have permissions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is link with : #32
1 : without
2 : with
The problem come from that when a subline is really long, the value delta/hypotenuse will be smaller than tolerance from belongsSegment for much more lines. In the example above, the point is linked with multiple sublines on the same line. But without a tolerance we will get only a random subline and then get the wrong locateOnLine value (linked with the wrong subline).