Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote control implementation #1

Merged
merged 17 commits into from
Jan 31, 2023
Merged

Conversation

maks-rafalko
Copy link
Owner

@maks-rafalko maks-rafalko commented Jan 9, 2023

General Information

Reviewer, see the README.md before checking for all the details about how to install and use the application.

Warning
Please note that @nutjs has issues with screenshots on Linux OS: nut-tree/nut.js#444

This code was tested on Windows - works correctly, on Manjaro linux - works correctly except screenshot - it's always empty, exactly how the issue above describes it. There are many students who are experiencing the same problem, so the issue is not in the code, but in the lib (or related libs) itself.

Self-review

Your rating - 164.0 points

Feedback on the points of the Terms of Reference:
Completed items:

  1. Implemented workable websocket server

  2. Websocket server message handler implemented properly

  3. Websocket server message sender implemented properly

  4. Move mouse up implemented properly

  5. Move mouse down implemented properly

  6. Move mouse left implemented properly

  7. Move mouse right implemented properly

  8. Send mouse coordinates implemented properly

  9. Draw circle implemented properly

  10. Draw rectangle implemented properly

  11. Draw square implemented properly

  12. Send screen image implemented properly (optionally)

  13. Task implemented on Typescript

  14. All data transfer operations with send/get should be performed using Streams API

  15. Codebase is separated (at least 4 modules)

@maks-rafalko maks-rafalko merged commit 343dd6d into main Jan 31, 2023
@maks-rafalko maks-rafalko deleted the feature/ws-remote-control branch January 31, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant