forked from rolling-scopes-school/websockets-ui
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote control implementation #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
force-pushed
the
feature/ws-remote-control
branch
from
January 11, 2023 12:25
170036f
to
20bc933
Compare
… Webpack. Add `nodeExternals()`
maks-rafalko
force-pushed
the
feature/ws-remote-control
branch
from
January 17, 2023 12:16
6862e5e
to
b3587d1
Compare
maks-rafalko
force-pushed
the
feature/ws-remote-control
branch
from
January 22, 2023 11:44
83fb7ee
to
a9f8891
Compare
maks-rafalko
force-pushed
the
feature/ws-remote-control
branch
from
January 22, 2023 11:45
a9f8891
to
a95b07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Information
Reviewer, see the README.md before checking for all the details about how to install and use the application.
Self-review
Your rating - 164.0 points
Feedback on the points of the Terms of Reference:
Completed items:
Implemented workable websocket server
Websocket server message handler implemented properly
Websocket server message sender implemented properly
Move mouse up implemented properly
Move mouse down implemented properly
Move mouse left implemented properly
Move mouse right implemented properly
Send mouse coordinates implemented properly
Draw circle implemented properly
Draw rectangle implemented properly
Draw square implemented properly
Send screen image implemented properly (optionally)
Task implemented on Typescript
All data transfer operations with send/get should be performed using Streams API
Codebase is separated (at least 4 modules)