forked from haskell-servant/servant
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty contexts. #1
Open
fisx
wants to merge
21
commits into
maksbotan:maksbotan/configurable-combinator-errors
Choose a base branch
from
zerobuzz:fisx/configurable-combinator-errors-empty-context
base: maksbotan/configurable-combinator-errors
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow empty contexts. #1
fisx
wants to merge
21
commits into
maksbotan:maksbotan/configurable-combinator-errors
from
zerobuzz:fisx/configurable-combinator-errors-empty-context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way for Servant users to customize formatting of error messages that arise when combinators can't parse URL or request body, apart from reimplementing those combinators for themselves or using middlewares. This commit adds a possibility to specify custom error formatters through Context. Fixes haskell-servant#685
Co-authored-by: fisx <mf@zerobuzz.net>
maksbotan
force-pushed
the
maksbotan/configurable-combinator-errors
branch
2 times, most recently
from
July 17, 2020 14:18
d2b3361
to
cb0224d
Compare
maksbotan
pushed a commit
that referenced
this pull request
Aug 5, 2020
* Create tests from the Example.hs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.