-
-
Notifications
You must be signed in to change notification settings - Fork 41
Feature/individual script host crates #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes which mostly clean up the structure of this crate, this enables 3rd parties to implement language hosts separately from this crate entirely, and makes it clearer what needs to be implemented and how to add support f or another language.
This also allows users to only depend on certain languages.
lua
is moved tobevy_mod_scripting_lua
rhai
is moved tobevy_mod_scripting_rhai
bevy_script_api
bevy_mod_scripting_core
impl_script_newtype
macro now requires#[derive(lua/rhai,..)]
attribute attached to the newtype and the right macro imported from the language's derive crate (i.e. lua ->bevy_mod_scripting_lua_derive
)lua impl {...}
, meaning multiple impl blocks can be used, one for each languageNot in this PR: ability for APIprovider to provide world,entity etc since right now those aren't available at all, main will break for a while
closes #26