feat: add option to emit response event on each callback & RunScriptCallback
command for "once-off" callbacks
#403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Largely, this is a refactor of the
commands
module, we now use a shared commandRunScriptCallback
to initiate internal callbacks. This command can also be used by consumers of BMS removing the need to have a full blown system to initiate one off callbacks.At the same time, this adds a
trigger_response
field to the script callback event, when this is set to true:ScriptCallbackResponseEvent
with the response payload from the scriptRunScriptCallback
command will do the sameThis should give users more flexibility in running "once-off" callbacks, especially if they require scripts to output something from them. At the moment the best bet is to either: