refactor: remove RuntimeContainer
& RuntimeSettings
, add plugin runtime to static world local settings
#471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Does what #470 did with context loading settings but for the runtime.
Since it's this is something we initialize once and then purely read (or modify through read refs), it can fit this model.
This leaves only 2 resources in the handler context
Migration Guide
RuntimeSettings
andRuntimeContainer
are removed, replace usages withP::readonly_settings(world.id()).runtime)
access to initializers is no longer possible outside the plugin setup phase