Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NN bugs #18

Open
mariloubodde opened this issue Jun 5, 2023 · 3 comments
Open

Fix NN bugs #18

mariloubodde opened this issue Jun 5, 2023 · 3 comments

Comments

@mariloubodde
Copy link
Collaborator

Fix bugs identified in first anospp production run
@mariloubodde
Copy link
Collaborator Author

The bug is in identify_error_seq()

It occurs when a sample has only unique (to the run) haplotypes at an amplicon, which meet the distance threshold to be identified as error sequences. Then the first sequence will be identified as an error sequence and in the previous code the second sequence cannot be compared to anything anymore, which causes the error.

I'm not sure what the right thing to do is, I have now settled for removing both sequences if they are unique to the run and sufficiently different from each other.

@amakunin
Copy link
Collaborator

@mariloubodde was this fixed in #20 ?

@mariloubodde
Copy link
Collaborator Author

@amakunin yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amakunin @mariloubodde