Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Compound Indexes #1

Merged
merged 2 commits into from
Jun 6, 2014
Merged

Conversation

jmikola
Copy link

@jmikola jmikola commented Apr 30, 2014

Additions for: doctrine#812

In-progress, so please don't merge yet. I'm going to use this PR to review/discuss changes, which can later be merged and allow me to merge a single PR on the Doctrine repo.

@malarzm
Copy link
Owner

malarzm commented Jun 5, 2014

@jmikola I'll merge your changes since allowLessEfficientIndexes is being removed and here's a reference to it. BTW I believe at least one method from FieldExtractor will not be used afterwards (namely getFieldsWithEqualityCondition() and change in getFieldsFromElemMatch()) - what do you think about leaving them for future use cases? Or should I remove them as well?

@malarzm
Copy link
Owner

malarzm commented Jun 5, 2014

Actually nevermind my comment about FieldExtractor I've just realized the method will still be needed

@jmikola
Copy link
Author

jmikola commented Jun 5, 2014

Feel free to merge this into your branch. If I have additional changes I can just open a new PR, but this will make reviewing doctrine#812 easier in the meantime with these changes in place :)

malarzm added a commit that referenced this pull request Jun 6, 2014
@malarzm malarzm merged commit 5624aae into malarzm:require_indexes Jun 6, 2014
@jmikola jmikola deleted the require_indexes branch June 6, 2014 15:23
malarzm pushed a commit that referenced this pull request Apr 3, 2015
Fix code to match coding standards required by doctrine/mongodb-odm team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants