DZD Metadata: controller - render ibgp/msdp peers#1035
Merged
Conversation
nikw9944
force-pushed
the
feature/controller-render-ibgp-peers
branch
from
7bd2dca to
f2b5422
Compare
nikw9944
changed the title
nikw9944
force-pushed
the
feature/controller-render-ibgp-peers
branch
from
f2b5422 to
b6d8a9d
Compare
packethog
requested changes
Aug 5, 2025
controlplane/controller/internal/controller/fixtures/e2e.peer.removal.txt
Outdated
Show resolved
Hide resolved
nikw9944
force-pushed
the
feature/controller-render-ibgp-peers
branch
2 times, most recently
from
de087a4 to
b21f458
Compare
packethog
requested changes
Aug 6, 2025
snormore
reviewed
Aug 6, 2025
nikw9944
force-pushed
the
feature/controller-render-ibgp-peers
branch
from
f1f2c54 to
c4d0d88
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the controller to automatically render iBGP and MSDP peers for VPNv4 and IPv4 address families, eliminating the operational nightmare of manually adding BGP peers to all devices every time a new device is added to the network.
Key changes include:
- Addition of VPNv4 and IPv4 iBGP peer configuration based on loopback interfaces
- Automatic MSDP peer configuration for multicast distribution
- Enhanced peer removal logic to only remove DZ-managed peer addresses
- Addition of required loopback interfaces to test fixtures
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| controlplane/controller/internal/controller/server.go | Core logic for building BGP peer lists from device loopback interfaces and filtering peer removal |
| controlplane/controller/internal/controller/templates/tunnel.tmpl | Template updates to render iBGP peers, address families, and MSDP configuration |
| controlplane/controller/internal/controller/models.go | Added BgpPeer struct and device interface tracking fields |
| e2e test files | Updated to create required Loopback255/256 interfaces for VPNv4/IPv4 peers |
| e2e fixtures | Updated expected configurations to include new iBGP and MSDP peer sections |
controlplane/controller/internal/controller/templates/tunnel.tmpl
Outdated
Show resolved
Hide resolved
controlplane/controller/internal/controller/templates/tunnel.tmpl
Outdated
Show resolved
Hide resolved
packethog
approved these changes
Aug 7, 2025
snormore
added a commit
that referenced
this pull request
Aug 7, 2025
## Summary of Changes - Update e2e telemetry test to wait for UDP/TWAMP rule to be applied by the controller-given config - Update e2e device startup config to unmerge the MGTM and main control plane ACL so prometheus metrics rule doesn't get overwritten when controller config is applied - Update e2e device startup config to not include the UDP/TWAMP rule and rely on the rule to be given by the controller - Follow-up on #1035 ## Testing Verification - Updated device telemetry e2e test to wait for controller config to be applied via TWAMP probes between devices
This was referenced Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready to merge until:
TODO 1: [DONE] Wait for #913 to be merged so the activator can assign interface IPs.
TODO 2: [DONE] Unit test demonstrating peer removal
TODO 3: [POSTPONED] e2e test demonstrating peer removal
TODO 4: [DONE] update ipv4/vpnv4 sub-sections of "router bgp" section
TODO 5: [DONE] add msdp and ipv4-only bgp peers
Summary of Changes
Testing Verification