Merged
Conversation
* Adds support for allocating IPs/segment IDs to interfaces. * Does not support reclaiming resources, this will be added in a later PR.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for allocating IPs and segment IDs to device interfaces in the activator component. The changes enable automatic assignment of segment routing IDs and IP addresses to device loopback interfaces, along with IP assignment to tunnel link interfaces during activation and deactivation processes.
- Adds segment routing ID allocation for device loopback interfaces
- Implements IP address assignment to tunnel interfaces during link activation/deactivation
- Updates device processing to handle interface metadata allocation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| smartcontract/sdk/rs/src/lib.rs | Adds interface-related type imports to support device interface handling |
| smartcontract/programs/doublezero-record/src/instruction.rs | Updates size_of usage to use std::mem::size_of for consistency |
| activator/src/process/link.rs | Implements IP assignment to device interfaces during link activation/deactivation |
| activator/src/process/device.rs | Adds segment routing ID and loopback IP allocation for device interfaces |
| activator/src/activator.rs | Integrates segment routing ID allocator and updates device processing |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nikw9944
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification