Conversation
packethog
force-pushed
the
feature/activator
branch
4 times, most recently
from
f3b8e13 to
7451dde
Compare
packethog
force-pushed
the
feature/activator
branch
from
7451dde to
c985f20
Compare
packethog
force-pushed
the
feature/activator
branch
from
c985f20 to
76ced18
Compare
nikw9944
approved these changes
Feb 21, 2025
vihu
added a commit
that referenced
this pull request
May 15, 2025
Summary ---- Attempt #2 to add multicast group support on the activator. This change enables the handling of both publisher and subscriber relationships in multicast groups, with appropriate tunnel allocation: - Publishers receive a dedicated tunnel and assigned IP for each multicast group - Subscribers share a single tunnel using their client IP - Added helper function to verify multicast group membership and activation status - Added is_activated() helper to MulticastGroup struct
packethog
added a commit
that referenced
this pull request
Jun 10, 2025
It looks like we need to maintain the user env for docker to pull public docker images in go tests if you don't have them locally already. Even though we don't login, docker complains about missing creds which points to not finding the user cred store at `$HOME/.docker/config.json`. This could be an artifact of having build kit enabled in the dev vm but this change fixes it nonetheless. Before: ``` root ➜ /workspaces/doublezero (fix/cleanup) $ make test ... #3 [internal] load metadata for docker.io/library/ubuntu:22.04 #3 ERROR: error getting credentials - err: exit status 255, out: `` #2 [internal] load metadata for docker.io/library/golang:1.24.3-alpine #2 CANCELED ------ > [internal] load metadata for docker.io/library/ubuntu:22.04: ------ e2e.dockerfile:6 -------------------- 4 | RUN go test -c -o /bin/example.test -tags e2e 5 | 6 | >>> FROM ubuntu:22.04 7 | RUN apt-get update && \ 8 | apt-get install -y ca-certificates -------------------- ERROR: failed to solve: ubuntu:22.04: failed to resolve source metadata for docker.io/library/ubuntu:22.04: error getting credentials - err: exit status 255, out: `` runner_test.go:149: failed to setup test runner: failed to build docker image ``` After: ``` root ➜ /workspaces/doublezero (fix/cleanup) $ make test ... test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.