feat: contributor account verification in multiple places #2539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR strengthens authorization controls by enforcing contributor identity verification across link management operations (suspend, resume, delete, and close). The key security improvement ensures that only the link owner or foundation-allowlisted payers can perform these privileged operations.
- Introduces
payer_in_foundationguard to differentiate between foundation authority and contributor ownership - Adds verification that
link.contributor_pk == contributor_account.keyfor non-foundation operations - Prevents unauthorized contributors from manipulating links they don't own
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| suspend.rs | Added contributor identity verification for link suspension operations |
| resume.rs | Added contributor identity verification for link resumption operations |
| delete.rs | Added contributor identity verification for link deletion operations |
| closeaccount.rs | Added contributor identity verification for link account closure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smartcontract/programs/doublezero-serviceability/src/processors/link/suspend.rs
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/link/resume.rs
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/link/delete.rs
Show resolved
Hide resolved
Contributor
|
@ANISH-SR Please, rebase to main |
ANISH-SR
force-pushed
the
feat/verification2
branch
from
aa2a0c8 to
d539866
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smartcontract/programs/doublezero-serviceability/src/processors/link/suspend.rs
Show resolved
Hide resolved
ANISH-SR
force-pushed
the
feat/verification2
branch
from
d539866 to
52ef266
Compare
ANISH-SR
force-pushed
the
feat/verification2
branch
from
52ef266 to
e1e531b
Compare
juan-malbeclabs
approved these changes
Jan 12, 2026
ANISH-SR
added a commit
to ANISH-SR/doublezero
that referenced
this pull request
Jan 20, 2026
…#2539) ## Summary of Changes * Enforced contributor identity across instructions to ensure contributor_account.key == link.contributor_pk where appropriate. * Preserved foundation/activator authority flows by introducing a payer_in_foundation guard: * Foundation-allowlisted payers bypass the contributor/link equality check in suspend, resume, and delete flows. * Prevents contributors from suspending, resuming, deleting, or closing links they do not own. * Establishes a consistent authorization invariant across all serviceability paths. * Still supports privileged foundation and activator workflows without breaking existing operational flows. ## Testing Verification * Existing unit and integration tests passed after updates. Closes malbeclabs#2213
ANISH-SR
added a commit
to ANISH-SR/doublezero
that referenced
this pull request
Jan 26, 2026
…#2539) ## Summary of Changes * Enforced contributor identity across instructions to ensure contributor_account.key == link.contributor_pk where appropriate. * Preserved foundation/activator authority flows by introducing a payer_in_foundation guard: * Foundation-allowlisted payers bypass the contributor/link equality check in suspend, resume, and delete flows. * Prevents contributors from suspending, resuming, deleting, or closing links they do not own. * Establishes a consistent authorization invariant across all serviceability paths. * Still supports privileged foundation and activator workflows without breaking existing operational flows. ## Testing Verification * Existing unit and integration tests passed after updates. Closes malbeclabs#2213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification
Closes #2213