feat: verify status is suspended #2545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Contributor
|
The suspended status was removed from devices and links. |
juan-malbeclabs
approved these changes
Jan 13, 2026
Contributor
juan-malbeclabs
left a comment
juan-malbeclabs
left a comment
There was a problem hiding this comment.
LGTM. No more Suspend on device & Link
ANISH-SR
added a commit
to ANISH-SR/doublezero
that referenced
this pull request
Jan 20, 2026
## Summary of Changes * All Resume* processors (Location, Exchange, Contributor, Device, User, Link) now require status == Suspended, otherwise return DoubleZeroError::InvalidStatus. * process_resume_link already enforced the correct status check and was left unchanged. * Every resume integration test now asserts a second resume fails with Custom(7) (InvalidStatus). * Resume operations are now strictly single-use from Suspended, with tests validating both success and misuse. ## Testing Verification * All rust checks green Closes malbeclabs#2222 --------- Signed-off-by: ANISH-SR <rawatanish08@gmail.com> Co-authored-by: Juan Olveira <juan@malbeclabs.com>
ANISH-SR
added a commit
to ANISH-SR/doublezero
that referenced
this pull request
Jan 26, 2026
## Summary of Changes * All Resume* processors (Location, Exchange, Contributor, Device, User, Link) now require status == Suspended, otherwise return DoubleZeroError::InvalidStatus. * process_resume_link already enforced the correct status check and was left unchanged. * Every resume integration test now asserts a second resume fails with Custom(7) (InvalidStatus). * Resume operations are now strictly single-use from Suspended, with tests validating both success and misuse. ## Testing Verification * All rust checks green Closes malbeclabs#2222 --------- Signed-off-by: ANISH-SR <rawatanish08@gmail.com> Co-authored-by: Juan Olveira <juan@malbeclabs.com>
thijsvanemmerik
pushed a commit
that referenced
this pull request
Feb 3, 2026
## Summary of Changes * All Resume* processors (Location, Exchange, Contributor, Device, User, Link) now require status == Suspended, otherwise return DoubleZeroError::InvalidStatus. * process_resume_link already enforced the correct status check and was left unchanged. * Every resume integration test now asserts a second resume fails with Custom(7) (InvalidStatus). * Resume operations are now strictly single-use from Suspended, with tests validating both success and misuse. ## Testing Verification * All rust checks green Closes #2222 --------- Signed-off-by: ANISH-SR <rawatanish08@gmail.com> Co-authored-by: Juan Olveira <juan@malbeclabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification
Closes #2222