Skip to content

feat: add verification in Delete #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ANISH-SR wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add verification in Delete #2546

ANISH-SR wants to merge 7 commits into from

Conversation

@ANISH-SR
Copy link
Contributor

@ANISH-SR ANISH-SR commented Jan 4, 2026

Summary of Changes

  • All Delete* processors now allow deletion only when status is Activated or Suspended.
  • New integration tests verify delete-from-Suspended for Location, Exchange, Contributor, and Device.
  • Delete-from-Activated paths for Link, User, and MulticastGroup were already covered by existing tests.
  • No regressions: Reference-count and authorization checks remain unchanged.
  • Changelog updated: Added an Unreleased note documenting the new Activated || Suspended requirement for all Delete* instructions.

Testing Verification

  • All lint checks green.

Closes #2223

@ANISH-SR
feat: add verification in Delete
2a6481d 
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
@ANISH-SR
chore: rust fmt
55210f2 
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
juan-malbeclabs
juan-malbeclabs approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@juan-malbeclabs juan-malbeclabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ANISH-SR and others added 2 commits January 9, 2026 22:31
@ANISH-SR
Merge branch 'main' into verify/status
f0f46ee
@ANISH-SR
chore: resolve merge conflict
45514d1 
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
@juan-malbeclabs juan-malbeclabs enabled auto-merge (squash) January 12, 2026 17:42
@martinsander00
Copy link
Contributor

martinsander00 commented Jan 21, 2026

@ANISH-SR could we resolve the conflicts here? :)

auto-merge was automatically disabled January 26, 2026 09:45

Head branch was pushed to by a user without write access

@ANISH-SR
Copy link
Contributor Author

ANISH-SR commented Jan 26, 2026

@ANISH-SR could we resolve the conflicts here? :)

on it!

@martinsander00
Copy link
Contributor

martinsander00 commented Jan 27, 2026

@ANISH-SR Looks like there is an issue with an e2e test here. Could you take a look? We are close to closing all Ottersec issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juan-malbeclabs juan-malbeclabs juan-malbeclabs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@ANISH-SR @martinsander00 @juan-malbeclabs