task: verify that accesspass.connection_count == 0 #2585
+117
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-malbeclabs
requested changes
Jan 9, 2026
Contributor
juan-malbeclabs
left a comment
juan-malbeclabs
left a comment
There was a problem hiding this comment.
Please, it’s important to add a regression test that validates the behavior of your change. Thank you very much.
| "AccessPass has active connections (connection_count={}), cannot close", | ||
| accesspass.connection_count | ||
| ); | ||
| return Err(DoubleZeroError::AccessPassNotFound.into()); |
Contributor
There was a problem hiding this comment.
@ANISH-SR To avoid confusion, could you create a new AccessPassInUse error so it’s clearer why it can’t be closed? Thanks.
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
Signed-off-by: ANISH-SR <rawatanish08@gmail.com>
ANISH-SR
force-pushed
the
verify-connection-count-2220
branch
from
39ccfb6 to
3c50b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Verification
Resolves #2220