Remove "unknown" status and add "failed" and "unreachable" statuses #2630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I believe there is no way to know if a link is unreachable due to a firewall issue specifically. However, what I did is infer this by checking whether the TCP connection was ever established before the timeout. The BGP plugin tracks two flags: |
martinsander00
force-pushed
the
ms/2622
branch
5 times, most recently
from
85d7113 to
7c02d22
Compare
packethog
requested changes
Jan 15, 2026
martinsander00
force-pushed
the
ms/2622
branch
2 times, most recently
from
aad9a4c to
f3f1fc8
Compare
martinsander00
force-pushed
the
ms/2622
branch
from
f3f1fc8 to
0602a4b
Compare
Resolves: #2622 Changed status name to short version
martinsander00
force-pushed
the
ms/2622
branch
from
0602a4b to
715cfe9
Compare
Jared-dz
reviewed
Jan 20, 2026
Jared-dz
left a comment
Jared-dz
left a comment
There was a problem hiding this comment.
This is an improvement to the current state. I am leaving comment without approval to allow time for second reviewer prior to merge.
packethog
approved these changes
Jan 20, 2026
thijsvanemmerik
pushed a commit
that referenced
this pull request
Feb 3, 2026
…2630) Resolves: #2622 ## Summary of Changes * Removed unknown status * Renamed status labels to be more descriptive: * pending → Pending BGP Session * initializing → Initializing BGP Session * down → BGP Session Down * up → BGP Session Up * Added BGP Session Failed (TCP connected but BGP handshake timed out after 5 seconds) * Added Network Unreachable (TCP connection failed, likely firewall issue) ## Testing Verification * Fixed existing tests * Added new tests
thijsvanemmerik
pushed a commit
that referenced
this pull request
Feb 3, 2026
…2630) Resolves: #2622 ## Summary of Changes * Removed unknown status * Renamed status labels to be more descriptive: * pending → Pending BGP Session * initializing → Initializing BGP Session * down → BGP Session Down * up → BGP Session Up * Added BGP Session Failed (TCP connected but BGP handshake timed out after 5 seconds) * Added Network Unreachable (TCP connection failed, likely firewall issue) ## Testing Verification * Fixed existing tests * Added new tests
thijsvanemmerik
pushed a commit
that referenced
this pull request
Feb 3, 2026
…2630) Resolves: #2622 ## Summary of Changes * Removed unknown status * Renamed status labels to be more descriptive: * pending → Pending BGP Session * initializing → Initializing BGP Session * down → BGP Session Down * up → BGP Session Up * Added BGP Session Failed (TCP connected but BGP handshake timed out after 5 seconds) * Added Network Unreachable (TCP connection failed, likely firewall issue) ## Testing Verification * Fixed existing tests * Added new tests
thijsvanemmerik
pushed a commit
that referenced
this pull request
Feb 3, 2026
…2630) Resolves: #2622 ## Summary of Changes * Removed unknown status * Renamed status labels to be more descriptive: * pending → Pending BGP Session * initializing → Initializing BGP Session * down → BGP Session Down * up → BGP Session Up * Added BGP Session Failed (TCP connected but BGP handshake timed out after 5 seconds) * Added Network Unreachable (TCP connection failed, likely firewall issue) ## Testing Verification * Fixed existing tests * Added new tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2622
Summary of Changes
Testing Verification