Skip to content

Comments

telemetry/geoprobe: add probe measurement and offset delivery#2916

Merged
nikw9944 merged 6 commits intomainfrom
bdz/doublezero-2899
Feb 11, 2026
Merged

telemetry/geoprobe: add probe measurement and offset delivery#2916
nikw9944 merged 6 commits intomainfrom
bdz/doublezero-2899

Conversation

@ben-dz
Copy link
Contributor

@ben-dz ben-dz commented Feb 11, 2026

Resolves: #2899

Summary of Changes

  • Add coordinator module for lifecycle management of geoprobe measurement operations
  • Add pinger module for TWAMP-based RTT measurements to child probes with retry support
  • Add publisher module for generating and delivering signed LocationOffset structures via UDP
  • Add security hardening including IP validation (reject private/loopback/link-local/reserved addresses), concurrency limits (100 max concurrent operations), reference chain validation, and DNS resolution timeout
  • Integrate geoprobe functionality into telemetry collector via new goroutine when --additional-child-probes CLI flag is provided
  • Add configuration validation for geoprobe dependencies (serviceability client and RPC client required when geoprobe enabled)
  • Extend main.go with --additional-child-probes and --management-namespace CLI flags
    This implements RFC16 Phase 1, item 1 (Telemetry agent extensions) and enables DZDs to measure RTT to child geoProbes, generate signed offset structures, and deliver them for geolocation verification.

Testing Verification

  • Comprehensive unit tests added for all new modules (coordinator, pinger, publisher, address validation)
  • Test coverage includes security validation, concurrency handling, error cases, and reference chain verification
  • Configuration validation tests verify proper dependency checks
  • All tests passing locally

@ben-dz ben-dz force-pushed the bdz/doublezero-2899 branch from 79899e5 to 8694419 Compare February 11, 2026 00:54
@ben-dz ben-dz added this to the Geo Location milestone Feb 11, 2026
@nikw9944 nikw9944 force-pushed the bdz/doublezero-2899 branch from 610485c to 15e28bc Compare February 11, 2026 03:53
@nikw9944 nikw9944 marked this pull request as ready for review February 11, 2026 05:43
@nikw9944 nikw9944 requested a review from snormore February 11, 2026 05:43
@nikw9944 nikw9944 force-pushed the bdz/doublezero-2899 branch from 31f13b5 to f2a1e24 Compare February 11, 2026 16:00
@nikw9944 nikw9944 requested a review from snormore February 11, 2026 16:01
@nikw9944 nikw9944 enabled auto-merge (squash) February 11, 2026 16:06
@nikw9944 nikw9944 merged commit d0b801e into main Feb 11, 2026
29 checks passed
@nikw9944 nikw9944 deleted the bdz/doublezero-2899 branch February 11, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geoprobe: telemetry agent extensions — probe measurement and offset delivery

3 participants