Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending CollectionCellAdapter; set the class as open #25

Closed
CureleaAndrei opened this issue Jun 6, 2019 · 1 comment
Closed

Extending CollectionCellAdapter; set the class as open #25

CureleaAndrei opened this issue Jun 6, 2019 · 1 comment
Assignees
@malcommac
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@CureleaAndrei
Copy link

CureleaAndrei commented Jun 6, 2019 •
edited
Loading

Hi, I am trying to extend CollectionCellAdapter so that all the logic that i want for this adapter to be encapsulated in a specific class. Doing so i get the folowing error : "Cannot inherit from non-open class 'CollectionCellAdapter<TrainingDayModel, DayCell>' outside of its defining module". Is there a way to extend CollectionCellAdapter?

P.S. : In the last library FlowKit you could do this

Ty, for this great library
malcommac added a commit that referenced this issue Sep 15, 2019
@malcommac
#25 CollectionCellAdapter is now an open class so you can create subc…
64b17a4 
…lasses of it to better encapsulate logic of the cell
@malcommac malcommac changed the title Extending CollectionCellAdapter Extending CollectionCellAdapter; set the class as open Sep 15, 2019
@malcommac
Copy link
Owner

CollectionCellAdapter is now open and subclassable.
Thanks for your report.

@malcommac malcommac self-assigned this Sep 15, 2019
@malcommac malcommac added the bug Something isn't working label Sep 15, 2019
@malcommac malcommac added this to the 1.1.0 milestone Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcommac malcommac

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@malcommac @CureleaAndrei