Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell is not passed inside didSelectItemAt of the CollectionDirector #29

Closed
wow-such-amazing opened this issue Jun 26, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wow-such-amazing
Copy link
Contributor

wow-such-amazing commented Jun 26, 2019

For example here it is explicitly set to nil

func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
    let (model, adapter) = context(forItemAt: indexPath)
    adapter.dispatchEvent(.didSelect, model: model, cell: nil, path: indexPath, params: nil)
}

And in most of the cases it is set to be nil

@malcommac malcommac self-assigned this Sep 15, 2019
@malcommac malcommac added this to the 1.1.0 milestone Sep 15, 2019
@malcommac malcommac added the bug Something isn't working label Sep 15, 2019
@malcommac
Copy link
Owner

Fixed, thanks

@malcommac malcommac changed the title Cell is not passed inside events Cell is not passed inside didSelectItemAt of the CollectionDirector Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants