Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for an issue that caused WeekStartDay to fail while initializing Region #786

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Vignesh-Thangamariappan

Ref: #690

Updated the Region initialiser as firstWeekday is getting reset on setting the locale
@ExtremeMan
Copy link

@malcommac this seems like a valid fix for a valid bug. Can we merge it? @Vignesh-Thangamariappan can you rebase?

@ExtremeMan
Copy link

ExtremeMan commented Nov 17, 2022

Or return back this method? 4.5.1...5.0.0#diff-4ddb0e769834923d6d637cfe9c9974c5d6d2c0e17c1703ac9ec3b7eaae5f68a9L89-L96

	/// Identify the first weekday of the calendar.
	/// By default is `sunday`.
	public var firstWeekday: WeekDay {
		set {
			self.calendar.firstWeekday = newValue.rawValue
		}
		get {
			return WeekDay(rawValue: self.calendar.firstWeekday)!
		}
	}

@Vignesh-Thangamariappan
Copy link
Author

Sure @ExtremeMan
I'm on it

@Vignesh-Thangamariappan
Copy link
Author

@malcommac Can you please review and merge these changes. Would be helpful for people facing #690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants