Update vidle.ts #39
Merged
Update vidle.ts #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malekim
requested changes
Feb 13, 2024
|
All requested changes complete |
malekim
approved these changes
Feb 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 54 55 +1
Branches 6 6
=========================================
+ Hits 54 55 +1 ☔ View full report in Codecov by Sentry. |
|
Looks like its missing, "SLACK_WEBHOOK" not sure environmental variable. |
fourgablesguy
added a commit
to fourgablesguy/v-idle-3
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to know when the timer was cleared (something happened).
The problem is, when the page is closed, the idle timer is destroyed, so when the page reopens, we dont know how long its been since they've been active. There are other use cases for this too.
#31
Lastly, if you don't plan on updating this package, we use this at my company, and I'm happy to help with the outstanding issues if you'd like.
(PS: Sorry for the double PR)