Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize test #378

Merged
merged 6 commits into from
May 15, 2024
Merged

Stabilize test #378

merged 6 commits into from
May 15, 2024

Conversation

n0v1
Copy link
Contributor

@n0v1 n0v1 commented May 15, 2024

After #377 was merged I noticed that tests sometimes still fail with No address added out of total 1 resolved. I opted to use get-port module to get real unused ports instead of using just some random number between 1000 and 65000.

With those changes test runs seem stable.

@anonrig
Copy link
Member

anonrig commented May 15, 2024

Can you also remove coveralls from GitHub actions?

@n0v1 n0v1 mentioned this pull request May 15, 2024
@n0v1
Copy link
Contributor Author

n0v1 commented May 15, 2024

Do you mean removing all stuff related to coveralls from .github/workflows/nodejs.yml? I noticed that sending coverage report failed every now and then with Can't add a job to a build that is already closed.. This should be fixed now by properly waiting until all parallel runs finished (208733e). Should I still remove coveralls?

@anonrig anonrig merged commit 5d6d08e into malijs:master May 15, 2024
4 checks passed
@anonrig
Copy link
Member

anonrig commented May 15, 2024

let's keep it as it is

@n0v1
Copy link
Contributor Author

n0v1 commented May 16, 2024

Thanks for merging! Now that tests are stable, is there any chance to release a new version soon? In particular to make mali compatible with @grpc/grpc-js v1.10.x (fixed by #375).

@n0v1 n0v1 deleted the modernize-tests-2 branch May 16, 2024 06:39
@anonrig
Copy link
Member

anonrig commented May 16, 2024

Yes I'll release a version today. Although, I'm not sure if I still have the permission. cc @bojand

@bojand
Copy link
Member

bojand commented May 16, 2024

Hello, yes you should still have write access to the NPM package. Please proceed.

@andres06-hub
Copy link

Hi, I think you have not created the version yet, could you help with this please.

@ScripterSugar
Copy link
Contributor

reminder ping @anonrig 🙏

@n0v1
Copy link
Contributor Author

n0v1 commented Jul 29, 2024

@anonrig, @bojand, is there anything blocking a new release including this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants