-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize test #378
Stabilize test #378
Conversation
Can you also remove coveralls from GitHub actions? |
Do you mean removing all stuff related to coveralls from .github/workflows/nodejs.yml? I noticed that sending coverage report failed every now and then with |
let's keep it as it is |
Thanks for merging! Now that tests are stable, is there any chance to release a new version soon? In particular to make mali compatible with @grpc/grpc-js v1.10.x (fixed by #375). |
Yes I'll release a version today. Although, I'm not sure if I still have the permission. cc @bojand |
Hello, yes you should still have write access to the NPM package. Please proceed. |
Hi, I think you have not created the version yet, could you help with this please. |
reminder ping @anonrig 🙏 |
After #377 was merged I noticed that tests sometimes still fail with
No address added out of total 1 resolved
. I opted to use get-port module to get real unused ports instead of using just some random number between 1000 and 65000.With those changes test runs seem stable.