Cleanup the CXX_FLAGS. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, move them all into DefaultCFlags.cmake, which cleans up the top-level quite a bit. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
hidmic
approved these changes
Dec 7, 2018
|
|
||
| set (CMAKE_C_FLAGS_DEBUG " -ggdb3 ${CMAKE_C_FLAGS_ALL}" CACHE INTERNAL "C Flags for debug" FORCE) | ||
| set (CMAKE_CXX_FLAGS_DEBUG ${CMAKE_C_FLAGS_DEBUG}) |
There was a problem hiding this comment.
@clalancette no more debug builds :'( ?
There was a problem hiding this comment.
I don't have a strong feeling about it, though the default build (RelWithDebugInfo) does have -g turned on. If you regularly use debug and/or think this is useful, I can put this back. Thoughts?
There was a problem hiding this comment.
does have -g turned on
If that's the case then I'm happy with the way it is.
|
Thanks @hidmic, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, move them all into DefaultCFlags.cmake, which
cleans up the top-level quite a bit.
This should fix the last bit of #472, allowing us to close that out.