Disables a test when running sanitizers. #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francocipollone
changed the title
scpeters
reviewed
May 5, 2020
test/regression/cpp/CMakeLists.txt
Outdated
|
|
||
| # TODO(francocipollone): Improve test suppression. | ||
| if (NOT ${SANITIZERS}) | ||
| # This test accuses a stack overflow in CI when running asan |
There was a problem hiding this comment.
Thanks! Done.
agalbachicar
previously approved these changes
May 5, 2020
|
Ready for a re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
asansimulation_run_stats_test.ccleads to astack overflow errorcaused by the gtest macroEXPECT_DEATHin combination withasan.The test was disabled when running sanitizers.