Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Agent pose bindings. #809

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Fixes Agent pose bindings. #809

merged 2 commits into from
Sep 20, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 20, 2021 •
edited
Loading

Resolves #808

  • Given that drake::Isometry3 is deprecated in newer versions I changed it to drake::PoseVector
  • Bindings were modified to correctly get translation and rotation pose out of an Agent.

@francocipollone francocipollone mentioned this pull request Sep 20, 2021
Merged
agalbachicar
agalbachicar requested changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add tests?

@francocipollone
Copy link
Collaborator Author

Can we also add tests?

Let me know if 7cbf943 meets the expectations.

agalbachicar
agalbachicar approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit ae9e5c2 into main Sep 20, 2021
@francocipollone francocipollone deleted the francocipollone/fixes_agent_bindings branch September 20, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent.get_pose() binding failing
2 participants
@francocipollone @agalbachicar