Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TeleopPlugin with ignition-gui 3 #372

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

agalbachicar
Copy link
Collaborator

  • Replicates UI from TeleopWidget which uses ign-gui0.
  • Implements the same functionality.
  • Missing automatic horizontal span.
teleop.mp4

To simplify reviewer's labor:

  • Key events were migrated to TeleopPlugin.qml because it is just simpler to handle there.
  • Button logic (change of label and driving flag) was migrated to TeleopPlugin.qml because it is just simpler to handle there.
  • Almost all state attributes are QProperties, it is way simpler to share state and do bindings.

I did not intend to change behavior, if you find anything odd please let me know.

Part of #332

- Replicates UI from TeleopWidget which uses ign-gui0.
- Implements the same functionality.
- Missing automatic horizontal span.
@agalbachicar agalbachicar merged commit 6441e8e into master Apr 1, 2021
@agalbachicar agalbachicar deleted the agalbachicar/#332_teleop_widget_in_ign_gui_3 branch April 1, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants