Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maliput viewer migration: UI for loading maps and rules. #381

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Maliput viewer migration: UI for loading maps and rules. #381

merged 3 commits into from
Apr 16, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Apr 15, 2021 •
edited
Loading

Solves:
Task 2 of #377 (comment)

  • Adds UI in order to select:
    • Map file.
    • RoadRulebook file.
    • TrafficLightBook file.
    • PhaseRingBook file.
  • Old visualizer's functionality is replicated.
  • UI was described in a separate QML file and imported from MaliputViewerPlugin.qml main file.

EDITED: The UI changed a bit after addressing this #381 (comment)

ui_load2.mp4

agalbachicar
agalbachicar previously approved these changes Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agalbachicar
agalbachicar approved these changes Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 925d592 into master Apr 16, 2021
@francocipollone francocipollone deleted the francocipollone/maliput_viewer_load_buttons branch April 16, 2021 19:15
@francocipollone francocipollone mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar