Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaliputViewer: Adds a table to show the lanes id. #391

Merged
merged 4 commits into from
May 7, 2021
Merged

MaliputViewer: Adds a table to show the lanes id. #391

merged 4 commits into from
May 7, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented May 4, 2021 •
edited
Loading

Part of Task 7 of #377 (comment)
It goes on top of: #390

  • Replicates the same functionality as the old visualizer.
    • All lanes id are shown in the table
    • When an id is clicked in the table the lane in the scene should be selected.
    • When clicking a lane the id in the table should be highlighted.
  • Ids shown in the table are sorted.
table_selecting2.mp4

This was referenced May 4, 2021
Merged
Closed
@francocipollone francocipollone force-pushed the francocipollone/ui_for_lane_selection branch 3 times, most recently from d36855c to ec50e99 Compare May 4, 2021 19:36
@francocipollone francocipollone marked this pull request as ready for review May 4, 2021 19:36
@francocipollone
Copy link
Collaborator Author

In 273d470 I just reduced the size of the table to leave space for future features.

@francocipollone francocipollone force-pushed the francocipollone/ui_for_lane_selection branch from af4538a to e6f6200 Compare May 5, 2021 15:40
@francocipollone francocipollone force-pushed the francocipollone/ui_for_lane_selection branch from e6f6200 to 955314b Compare May 5, 2021 16:13
@francocipollone francocipollone mentioned this pull request May 5, 2021
Merged
1 task
agalbachicar
agalbachicar previously approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. It LGTM.

delphyne_gui/visualizer/LanesListArea.qml Outdated Show resolved Hide resolved
delphyne_gui/visualizer/LanesListArea.qml Outdated Show resolved Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin.cc Show resolved Hide resolved
agalbachicar
agalbachicar approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 1c996cf into master May 7, 2021
@francocipollone francocipollone deleted the francocipollone/ui_for_lane_selection branch May 7, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar