Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes layout selection. #459

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 22, 2021

Related to maliput/delphyne#806

The logic of the launch_visualizer method is improved to be able to load layouts not only from the DELPHYNE_GUI_RESOURCE_ROOT location but also if an absolute path is passed as well as a relative path from the execution folder.

This impacts on the demos (delphyne_demos) where now they can be executed using different layouts
maliput/delphyne_demos#29

@francocipollone francocipollone force-pushed the francocipollone/fixes_gui_configuration branch from 6c2af80 to 987af3b Compare September 22, 2021 15:14
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits.

delphyne_gui/python/utilities.py Show resolved Hide resolved
delphyne_gui/python/utilities.py Show resolved Hide resolved
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 052c652 into main Sep 23, 2021
@francocipollone francocipollone deleted the francocipollone/fixes_gui_configuration branch September 23, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants