Provides support for RoadGeometry::IdIndex methods. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
This was referenced Mar 19, 2024
agalbachicar
requested changes
Mar 20, 2024
maliput-sys/src/api/mod.rs
Outdated
| @@ -50,6 +56,8 @@ pub mod ffi { | |||
| rg: &RoadGeometry, | |||
| inertial_position: &InertialPosition, | |||
| ) -> UniquePtr<RoadPositionResult>; | |||
| fn RoadGeometry_GetLane(rg: &RoadGeometry, lane_id: &String) -> *const Lane; | |||
There was a problem hiding this comment.
Isn't it better to return a ConstLanePtr instead of a *const Lane?
There was a problem hiding this comment.
The use of ConstLanePtr is due to a workaround in the GetLanes method. Not sure if it is "better" but I did it for consistency.
Done.
maliput/src/api/mod.rs
Outdated
Comment on lines
133
to
141
| let mut lanes_vec = Vec::new(); | ||
| for lane in lanes { | ||
| unsafe { | ||
| lanes_vec.push(Lane { | ||
| lane: lane.lane.as_ref().expect(""), | ||
| }); | ||
| } | ||
| } | ||
| lanes_vec |
There was a problem hiding this comment.
I think you can do the following:
lanes.into_iter().map(| l | Lane { lane: l.lane.as_ref().expect("") }).collect::<Vec<Lane>>()There was a problem hiding this comment.
Nice! Keep dropping more rust good practices 😄
Done.
| if (lanes.size() == lanes_cpp.size()) { | ||
| return lanes; | ||
| } | ||
| for (const auto& lane : road_geometry.ById().GetLanes()) { |
There was a problem hiding this comment.
Suggested change
| for (const auto& lane : road_geometry.ById().GetLanes()) { | |
| lanes.reserve(lanes_cpp.size()); | |
| for (const auto& lane : road_geometry.ById().GetLanes()) { |
There was a problem hiding this comment.
Nice.
Done.
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related to #31 #36
Summary
Methods provided by the RoadGeometry::IdIndex subclass are directly added to the RoadGeometry API class.
This is convenient as subclasses declaration (IdIndex within RoadGeometry) isn't compatible with the binding process.
Documentation was added to the class
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.