Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and ENV variable in Dockerfile.nvidia and reorder the file to match the old sequence. #214

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

agalbachicar
Copy link
Collaborator

See here. In particular this line has a typo.

It has been found while investigating maliput/delphyne_gui#405

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment:

@francocipollone
Copy link
Collaborator

CI failing because: https://github.com/ToyotaResearchInstitute/malidrive/pull/765

Co-authored-by: Franco Cipollone <53065142+francocipollone@users.noreply.github.com>
@agalbachicar
Copy link
Collaborator Author

@francocipollone half of the tests ran after your commit. I don't think it's necessary to run them again to do exactly the same thing. If you agree please approve and we can proceed merging this one.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go!

@agalbachicar agalbachicar merged commit ba26db1 into main Jun 14, 2021
@agalbachicar agalbachicar deleted the agalbachicar/restore_old_nvidia_docker_image branch June 14, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants