Enables regression testing in bazel.

[francocipollone]

🎉 New feature

closes #247

Summary

• Now that maliput::test_utilities is gtest-free: Make test_utilities library non gtest dependant maliput#591
  we can enable bazel testing in maliput_malidrive
• Builds test_utilities with bazel. maliput#608 is necessary to correctly build tests.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if it affects the public API)

[stonier]

LGTM

[francocipollone]

@stonier One quick question as you have experience here. PR in maliput has been merged, now the test_utilities library is part of maliput.
However, here the bazel job isn't finding that library.
Do we have to manually push to BCR maliput like a "new release"?

[francocipollone]

@stonier One quick question as you have experience here. PR in maliput has been merged, now the test_utilities library is part of maliput. However, here the bazel job isn't finding that library. Do we have to manually push to BCR maliput like a "new release"?

Friendly ping here @stonier

[francocipollone]

I retriggered CI and now it is failing due to another issue not related to this PR:

ERROR: Error computing the main repository mapping: in module dependency chain <root> -> bazel_tools@_ -> rules_cc@0.0.9: module not found in registries: rules_cc@0.0.9

[francocipollone]

I retriggered CI and now it is failing due to another issue not related to this PR:

ERROR: Error computing the main repository mapping: in module dependency chain <root> -> bazel_tools@_ -> rules_cc@0.0.9: module not found in registries: rules_cc@0.0.9

This is fixed

[francocipollone]

@stonier One quick question as you have experience here. PR in maliput has been merged, now the test_utilities library is part of maliput. However, here the bazel job isn't finding that library. Do we have to manually push to BCR maliput like a "new release"?

Going back to this. I assume we have to create a maliput release that ships test_utilities library. Correct? @stonier

[francocipollone]

This library only contains the test/assert_compare.h header file that is used in serveral test under regression folder.

I tried using visibility:private but I can't add this target as dep to a cc_test statement because there is no visibility.

[agalbachicar]

You need to use __subpackages__, see https://bazel.build/concepts/visibility#visibility-specifications

[francocipollone]

Thanks! Done at ffa0582

[francocipollone]

Pendings:

• private_test_headers targets aren't really private as I want to use it in the test targets. (as commented here Enables regression testing in bazel. #246 (comment))
• Plugin tests weren't enabled as the test suite for testing the plugin architecture isn't well set up for bazel.
  • This should be probably tackled in a follow-up PR so I will create an issue for this [Bazel] Enable test for plugin #268

[agalbachicar]

PTAL

[agalbachicar]

You need to use __subpackages__, see https://bazel.build/concepts/visibility#visibility-specifications

[agalbachicar]

I suggest you also allow to pass a list of target dependencies.
That will allow to select in each library the target link dependencies and pair it to what we do in cmake.
I also prefer to have the for loop in each BUILD.bazel file and only pass here the src list with just one file instead of the entire list. It is a matter of composability.
Note you also have the ability to pass in kwargs and default values --> https://bazel.build/rules/macro-tutorial . That could help with target customization. For instance, if we have at some point a test that deserves promotion to size="medium" we could use default values and override the default "small".

[francocipollone]

I suggest you also allow to pass a list of target dependencies.
That will allow to select in each library the target link dependencies and pair it to what we do in cmake.

I understand that this is solution is actually better.

However I tried to replicate the current CMake setup, and in the current CMake setup we link to all the targets: https://github.com/maliput/maliput_malidrive/blob/eb547917ac19c1d56efdc5ab09665e49e9571e97/test/CMakeLists.txt

[stonier]

If bazel test //... now does something, you could/should enable them in https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml

Otherwise, LGTM.

[francocipollone]

I will proceed and merge it

[francocipollone]

If bazel test //... now does something, you could/should enable them in https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml

Otherwise, LGTM.

Done!