Add tests to ROS node #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates MaliputQueryNode as a ROS2 proxy to make RoadNetwork queries. - Provides a sample configuration file use maliput_malidrive. Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
francocipollone
requested changes
Jan 6, 2023
Comment on lines
+255
to
+256
| rclcpp::Event::SharedPtr graph_event = node->get_graph_event(); | ||
| node->wait_for_graph_change(graph_event, sleep_period); |
There was a problem hiding this comment.
Just to fully understand the logic here, which are the graph events here? RElated to the lifecycle states?
node->wait_for_graph_change(graph_event, sleep_period);
Are we waiting here for the graph_event to happen? or are we waiting to change from graph_event instead?
There was a problem hiding this comment.
- NodeInterface::get_graph_event() returns an event that will be set when the event occurs.
- NodeInterface::wait_for_graph_change() waits for graph_event to be set.
We are waiting for an event to occur.
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
|
Interestingly, maliput_ros_interfaces failed at bf1e6ed [...]
Summary: 3 packages finished [34.7s]
1 package had stderr output: maliput_ros_interfaces
1 package had test failures: maliput_ros_interfacespep 257 check failed in one of the tests that the code generation automatically creates. |
francocipollone
previously approved these changes
Jan 8, 2023
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #1
Goes on top of #8
Summary
Adds test coverage to the ROS2 and MaliputQuery. To do, I've done the following:
In the process learned that there should be a ros2 way to indicate a service call has failed, I'll do that in a follow up PR.
Test it
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.