Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes tests to avoid breaking CI with generated files. #13

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Removes tests to avoid breaking CI with generated files. #13

merged 2 commits into from
Jan 10, 2023

Conversation

agalbachicar
Copy link
Collaborator

🦟 Bug fix

Part of #12

Summary

  • Removes extra tests over the generated files.
  • Removes a build warning for shared libraries.
  • Updates the setup-ros version in CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@agalbachicar
Updates setup-ros to v0.4 from v0.3.
411e66f 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Solves a build warning and removes tests from rosidl_generete_interfa…
f1b5cc9 
…ces().

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
francocipollone
francocipollone approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar marked this pull request as ready for review January 10, 2023 15:02
@agalbachicar agalbachicar merged commit 8712a23 into main Jan 10, 2023
@agalbachicar agalbachicar deleted the agalbachicar/fix_ci_pep257 branch January 10, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francocipollone francocipollone francocipollone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agalbachicar @francocipollone