Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample lane s route #21

Merged
merged 27 commits into from
Jan 30, 2023
Merged

Sample lane s route #21

merged 27 commits into from
Jan 30, 2023

Conversation

agalbachicar
Copy link
Collaborator

@agalbachicar agalbachicar commented Jan 21, 2023 •
edited
Loading

🎉 New feature

Part of #1
Goes on top of #20

Summary

It adds the service /sample_lane_s_route to allow a LaneSRoute path to be sampled and obtain a vector of InertialPositions out of it.

Test it

Via unit tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@agalbachicar
Creates a base package to execute queries.
39ac9ea 
- Creates MaliputQueryNode as a ROS2 proxy to make RoadNetwork queries.
- Provides a sample configuration file use maliput_malidrive.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Addresses comments.
10e54a1 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Add tests to MaliputQuery.
4814a26 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Add tests to MaliputQueryNode.
b6df3ed 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Replaces gmock defines for the new versions.
f320184 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Missing end of line.
e4cfd6a 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Solves the non-mutable YAML configuration parameter.
6dd66cd 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds dependencies to CI.
bf1e6ed 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds new mocks and standardizes the macros.
663fec7 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds test to MaliputQuery.
e38289e 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds the junction service call and its tests.
b1331e1 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Fixes docstring.
b029bef 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds the service call creation.
9a2dbeb 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Merge branch 'main' into agalbachicar/#1_add_get_junction_service
7a23e3f 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds a segment to obtain Segments by ID.
cc6e354 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds lane service.
66bf715 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds branch_point service.
21391e1 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Splits maliput_query_node_tests into multiple files per service.
08058f4 
- Moves specifc service request tests to individual files.
- Creates a function to make a service request and return the result.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Merge branch 'main' into agalbachicar/#1_refactor_tests_to_scale_buil…
5a578e2 
…d_time
@agalbachicar
Adds ToRoadPosition and FindRoadPositions as service calls.
fb05a86 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds a service to obtain the INERTIAL Frame pose of a given RoadPosit…
ab961f6 
…ion.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds a service to obtain the LANE Frame derivatives at a given RoadPo…
a07d8c3 
…sition.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds a query to retrieve lane boundaries at a RoadPosition.
30fa63f 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds ToRoadPosition and FindRoadPositions as service calls.
8af20a3 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds a query to derive LaneSRoutes from two RoadPositions.
e9aa3cd 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar
Adds a service to sample a LaneSRoute.
d8271ad 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar agalbachicar mentioned this pull request Jan 21, 2023
Open
22 tasks
francocipollone
francocipollone previously approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maliput_ros_interfaces/srv/SampleLaneSRoute.srv Show resolved Hide resolved
@agalbachicar
Copy link
Collaborator Author

Will sync and update soon this PR.

@agalbachicar
Merge branch 'main' into agalbachicar/#1_sample_lane_s_route
5a5e4b0 
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar agalbachicar marked this pull request as ready for review January 25, 2023 13:40
@agalbachicar
Copy link
Collaborator Author

@francocipollone whenever you have a minute, I'll appreciate your review here.

francocipollone
francocipollone approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit fe9a808 into main Jan 30, 2023
@agalbachicar agalbachicar deleted the agalbachicar/#1_sample_lane_s_route branch January 30, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francocipollone francocipollone francocipollone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agalbachicar @francocipollone