Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete tests for geometric type translations #5

Conversation

agalbachicar
Copy link
Collaborator

🎉 New feature

Part of #1

Summary

Completes the missing testing in #4.

Test it

Automatic unit tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
- Provides a package with message descriptions for RoadGeometry, BranchPoint, Junction, Lane and Segment Ids.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
@agalbachicar agalbachicar force-pushed the agalbachicar/#1_complete_tests_for_geometric_type_translations branch from a697498 to 226f79b Compare December 30, 2022 15:51
@agalbachicar agalbachicar merged commit 1edbf27 into main Dec 30, 2022
@agalbachicar agalbachicar deleted the agalbachicar/#1_complete_tests_for_geometric_type_translations branch December 30, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants