Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create maliput_ros package #7

Merged
merged 5 commits into from
Dec 30, 2022

Conversation

agalbachicar
Copy link
Collaborator

🎉 New feature

Part of #1

Summary

Creates maliput_ros package and brings in the library to parse YAML configuration to load a RoadNetwork from a plugin.
Originally, that library was introduced in maliput/maliput_viz#18 , and it was brought here, adapted and complemented with tests.

Test it

See unit tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
This function has been copied from maliput_viz, inserted in
maliput/maliput_viz#18 and adapted for this
package plus tests.

Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agalbachicar agalbachicar merged commit f1452b7 into main Dec 30, 2022
@agalbachicar agalbachicar deleted the agalbachicar/#1_create_maliput_ros_package branch December 30, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants